maint: improves `domain` module #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

yozachar merged 1 commit into python-validators:master from yozachar:workshop

Mar 3, 2023

Collaborator

yozachar commented Mar 2, 2023 •

edited

Loading

maint: improves domain module

Uses type hints, improve docs
Regards RFC 1034 and RFC 2782
Updates corresponding test functions

Related items

Issues

Closes Allows commas in domain validator #52
Closes ValidationFailure on real domains with accent characters #74
Closes Valid domain name taken as invalid #81
Closes Methods using regex ignore the last \n . #89
Closes valid domain return an invalid error #95
Closes Domain with colons at beginning returns True #120
Closes domain validator fails for fully qualified ("absolute") domain names #124
Closes www.google.com. is not a valid domain #141
Closes Domain not handle None object #143
Closes Falsely detects unicode with FULL STOP as valid domain (eg ⒈com) #199
Closes Bug, hostname with trailing dot throws exception #204

PRs

yozachar added the review label

yozachar self-assigned this

yozachar force-pushed the workshop branch 3 times, most recently from 10a853d to 5e58cb3 Compare

March 2, 2023 06:30


          maint: improves domain module

- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes python-validators#52
- Closes python-validators#74
- Closes python-validators#81
- Closes python-validators#89
- Closes python-validators#95
- Closes python-validators#120
- Closes python-validators#124
- Closes python-validators#141
- Closes python-validators#143
- Closes python-validators#199
- Closes python-validators#204

*PRs*

- Closes python-validators#114
- Closes python-validators#179

yozachar force-pushed the workshop branch from 5e58cb3 to 7489857 Compare

March 2, 2023 06:33

yozachar merged commit 8f596c3 into python-validators:master

yozachar added maintenance and removed review labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment